Allow setting official check mode configuration via environment variable #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvanocerza
suggested changes
Nov 23, 2020
per1234
force-pushed
the
per1234/official-mode
branch
from
80115b7 to
5ac108e
Compare
silvanocerza
approved these changes
Nov 23, 2020
Since the official mode should only be used when checking official Arduino projects, I thought it was not a good idea to add a flag for this setting, since it could cause confusion to the those using the tool to check 3rd party projects, who have no use for this setting.
per1234
force-pushed
the
per1234/official-mode
branch
from
5ac108e to
24cae53
Compare
per1234
added
topic: code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the official mode should only be used when checking official Arduino projects, I thought it was not a good idea to
add a flag for this setting, since it could cause confusion to the those using the tool to check 3rd party projects, who
have no use for this setting.