Add schema-based rules for pluggable monitor dependencies data of package index #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for a new optional `packages[*].platforms[*].monitorDependencies` field in the Arduino package index format has been added to Arduino CLI. Since the package index JSON schema does not allow additional properties in `packages[*].platforms[*]`, package indexes using this new property would previously fail validation against the schema.
There was an inefficient approach to populating the project data for package index components, where the slices were iterated over redundantly for each of the components they contained. At first perhaps a reasonable tradeoff for the sake of consistency and readability, the redundancy has became more significant over time as new components are added. With the pending addition of yet another for pluggable monitor support, it seems best to refactor now.
per1234
added
type: enhancement
Codecov Report
@@ Coverage Diff @@
## main #293 +/- ##
==========================================
+ Coverage 89.79% 89.95% +0.15%
==========================================
Files 44 44
Lines 6626 6728 +102
==========================================
+ Hits 5950 6052 +102
Misses 553 553
Partials 123 123
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
internal/project/projectdata/testdata/packageindexes/empty-ids/package_foo_index.json
Outdated
Show resolved
Hide resolved
silvanocerza
suggested changes
Nov 12, 2021
These are the JSON schema-based rules to check the `packages[].platforms[].monitorDependencies[]`-level data of the Arduino Package Index.
silvanocerza
approved these changes
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the JSON schema-based rules to check the
packages[].platforms[].monitorDependencies[]-level data of Arduino Package Index projects.