Add slice entries to projectdata for all package index components #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to provide rule results, it's necessary to identify even completely invalid package index components. The previous behavior of skipping these components did not allow that.
Codecov Report
@@ Coverage Diff @@
## main #191 +/- ##
==========================================
+ Coverage 84.03% 84.22% +0.19%
==========================================
Files 43 43
Lines 3201 3202 +1
==========================================
+ Hits 2690 2697 +7
+ Misses 396 393 -3
+ Partials 115 112 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
silvanocerza
approved these changes
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to provide rule results, it's necessary to identify even completely invalid package index components. The
previous behavior of skipping these components did not allow that.