Various minor improvements to unit tests for package index projects #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
per1234
commented
Jun 14, 2021
per1234
commented
- Use more appropriate packager name in test data package indexes
- Add test messages to all package index project data tests
- Correct order of arguments in test equality assertions
The previous "myboard" packager name was inherited from the sample package index in the specification, but it is not a very intuitive packager name so it might cause confusion.
This makes it possible to identify which test table item a test failure was associated with.
The order of the arguments is expected, actual. I had it backwards, resulting in very confusing test failure messages.
per1234
added
type: bug
type: enhancement
Codecov Report
@@ Coverage Diff @@
## main #190 +/- ##
=======================================
Coverage 84.03% 84.03%
=======================================
Files 43 43
Lines 3201 3201
=======================================
Hits 2690 2690
Misses 396 396
Partials 115 115
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
silvanocerza
approved these changes
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.