Skip to content

Add rules to check loading of URLs in package index #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2021
Merged

Add rules to check loading of URLs in package index #189

merged 2 commits into from
Jun 11, 2021

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Jun 11, 2021

These rules check whether the various URLs provided in the package index data can be loaded.

per1234 added 2 commits June 11, 2021 01:30
Previously only used for a single library.properties function, multiple planned package index rules will need to do this
as well. So it is best to share the code between all of them.
These rules check whether the various URLs provided in the package index data can be loaded.
@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jun 11, 2021
@per1234 per1234 requested review from silvanocerza and umbynos June 11, 2021 08:42
@codecov-commenter
Copy link

Codecov Report

Merging #189 (6b82e86) into main (e462881) will decrease coverage by 0.35%.
The diff coverage is 71.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #189      +/-   ##
==========================================
- Coverage   84.39%   84.03%   -0.36%     
==========================================
  Files          43       43              
  Lines        3121     3201      +80     
==========================================
+ Hits         2634     2690      +56     
- Misses        384      396      +12     
- Partials      103      115      +12     
Flag Coverage Δ
unit 84.03% <71.76%> (-0.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ternal/rule/ruleconfiguration/ruleconfiguration.go 100.00% <ø> (ø)
internal/rule/rulefunction/packageindex.go 71.71% <68.42%> (-10.90%) ⬇️
internal/rule/rulefunction/library.go 94.76% <100.00%> (-0.03%) ⬇️
internal/rule/rulefunction/rulefunction.go 81.48% <100.00%> (+2.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e462881...6b82e86. Read the comment docs.

@per1234 per1234 merged commit 3d2ae4c into arduino:main Jun 11, 2021
@per1234 per1234 deleted the package-index-urls branch June 11, 2021 09:00
@per1234 per1234 self-assigned this Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants