Allow full JSON pointers in schema validation result parsing functions #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
added
type: enhancement
Codecov Report
@@ Coverage Diff @@
## main #186 +/- ##
=======================================
Coverage 84.45% 84.45%
=======================================
Files 43 43
Lines 3082 3082
=======================================
Hits 2603 2603
Misses 380 380
Partials 99 99
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
umbynos
approved these changes
Jun 11, 2021
When used with the "properties" data format, and most especially with the flat format of the library.properties file that was an initial focus of the project's development, JSON pointers are not a terribly intuitive way to refer to a data path. In this context, it seemed sensible to pre-fill the root prefix on the instance pointer argument of the JSON schema validation result parsing functions. However, now that those functions are being used with the JSON formatted package index data file, the requirement to omit this prefix from the JSON pointers is very confusing. Since the argument is already a regex, it's simple to allow both styles of instance data path references.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When used with the "properties" data format, and most especially with the flat format of the library.properties file that was an initial focus of the project's development, JSON pointers are not a terribly intuitive way to refer to a data path.
In this context, it seemed sensible to pre-fill the root prefix on the instance pointer argument of the JSON schema validation result parsing functions. However, now that those functions are being used with the JSON formatted package index data file, the requirement to omit this prefix from the JSON pointers is very confusing.
Since the argument is already a regex, it's simple to allow both styles of instance data path references.