Use most appropriate function for checking URL #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the http.Get() documentation: > Caller should close resp.Body when done reading from it. This was not done previously. Since the body is not needed, http.Head() is more appropriate for this application and it does not impose the requirement to add additional code to clean up.
Codecov Report
@@ Coverage Diff @@
## main #185 +/- ##
=======================================
Coverage 84.37% 84.37%
=======================================
Files 43 43
Lines 3078 3078
=======================================
Hits 2597 2597
Misses 381 381
Partials 100 100
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
cmaglie
approved these changes
Jun 7, 2021
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the
http.Get()documentation:This was not done previously. Since the body is not needed,
http.Head()is more appropriate for this application and itdoes not impose the requirement to add additional code to clean up.