Skip to content

Make sketch filename matching rule case-sensitive #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 17, 2021
Merged

Make sketch filename matching rule case-sensitive #162

merged 3 commits into from
Feb 17, 2021

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Feb 17, 2021

The primary sketch file name must match the sketch folder exactly. Previously, the sketch file name matching rule (SS001) did not check for file name case matching on case-insensitive file systems.

The primary sketch file name must match the sketch folder exactly. Previously, the rule did not check for file name case
matching on case-insensitive file systems.
Remove unused dependencies from go.sum
@codecov-io
Copy link

Codecov Report

Merging #162 (1f72538) into main (9477e68) will increase coverage by 0.00%.
The diff coverage is 71.42%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #162   +/-   ##
=======================================
  Coverage   84.26%   84.27%           
=======================================
  Files          43       43           
  Lines        2956     2957    +1     
=======================================
+ Hits         2491     2492    +1     
  Misses        373      373           
  Partials       92       92           
Flag Coverage Δ
unit 84.27% <71.42%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/rule/rulefunction/sketch.go 92.59% <71.42%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09f7530...1f72538. Read the comment docs.

@per1234
Copy link
Contributor Author

per1234 commented Feb 17, 2021

I had to make 83c70fd in order to make the "Check for forgotten code generation" step of the "Run tests" workflow pass (https://github.com/per1234/arduino-lint/runs/1918271782?check_suite_focus=true#step:6:15), but this is not in any way related to the code changes made in this PR.

@per1234 per1234 requested a review from ubidefeo February 17, 2021 12:11
@per1234 per1234 merged commit 15c986b into arduino:main Feb 17, 2021
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Sep 29, 2021
@per1234 per1234 self-assigned this Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants