Skip to content

Reduce unnecessary log output #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 12, 2021
Merged

Reduce unnecessary log output #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd76231
Use appropriate log level for programmers.txt/platform.txt load failure
per1234 Jan 12, 2021
94a19c1
Set logging level to fatal when running platform rule function tests
per1234 Jan 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/project/projectdata/platform.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ func InitializeForPlatform(project project.Type) {

programmersTxt, programmersTxtLoadError = programmerstxt.Properties(ProjectPath())
if programmersTxtLoadError != nil {
logrus.Errorf("Error loading programmers.txt from %s: %s", project.Path, programmersTxtLoadError)
logrus.Tracef("Error loading programmers.txt from %s: %s", project.Path, programmersTxtLoadError)
programmersTxtSchemaValidationResult = nil
} else {
programmersTxtSchemaValidationResult = programmerstxt.Validate(programmersTxt)
Expand All @@ -56,7 +56,7 @@ func InitializeForPlatform(project project.Type) {

platformTxt, platformTxtLoadError = platformtxt.Properties(ProjectPath())
if platformTxtLoadError != nil {
logrus.Errorf("Error loading platform.txt from %s: %s", project.Path, platformTxtLoadError)
logrus.Tracef("Error loading platform.txt from %s: %s", project.Path, platformTxtLoadError)
platformTxtSchemaValidationResult = nil
platformTxtToolNames = nil
} else {
Expand Down
2 changes: 2 additions & 0 deletions internal/rule/rulefunction/platform_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,14 @@ import (
"github.com/arduino/arduino-lint/internal/project/projecttype"
"github.com/arduino/arduino-lint/internal/rule/ruleresult"
"github.com/arduino/go-paths-helper"
"github.com/sirupsen/logrus"
"github.com/stretchr/testify/assert"
)

var platformTestDataPath *paths.Path

func init() {
logrus.SetLevel(logrus.FatalLevel)
workingDirectory, err := paths.Getwd()
if err != nil {
panic(err)
Expand Down