Check custom board options for required properties #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
force-pushed
the
per1234/board-options
branch
from
383677d to
259efba
Compare
boards.txt properties may be defined either directly under the board ID, or in the custom board options. So the schema and rule functions must be made to check both places. Unfortunately, JSON schema doesn't have the capability to define required properties that can be defined at either path, so those rules are now handled in pure Go code.
per1234
force-pushed
the
per1234/board-options
branch
from
259efba to
014bb0a
Compare
silvanocerza
approved these changes
Jan 12, 2021
per1234
added
topic: code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
boards.txt properties may be defined either directly under the board ID, or in the custom board options. So the schema and rule functions must be made to check both places.
Unfortunately, JSON schema doesn't have the capability to define required properties that can be defined at either path, so those rules are now handled in pure Go code.