Skip to content

Use Codecov for recording and reporting code coverage information #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2021

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Dec 13, 2020

No description provided.

Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@per1234 we don't have a CODECOV_TOKEN secret ATM, the coverage upload will start working when we open the repo to the public.
This is ok to me but I just wanted to have a confirmation from you that this was your original idea :)

@per1234
Copy link
Contributor Author

per1234 commented Dec 21, 2020

Yes, that's correct. I had this in a branch in my local repo so I decided to push it to the main repo for the sake of transparency, but put it in "Draft" mode because it doesn't make sense to merge it until the repo is public.

@per1234 per1234 marked this pull request as ready for review January 13, 2021 01:48
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@bf0d1b4). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #108   +/-   ##
=======================================
  Coverage        ?   84.26%           
=======================================
  Files           ?       43           
  Lines           ?     2956           
  Branches        ?        0           
=======================================
  Hits            ?     2491           
  Misses          ?      373           
  Partials        ?       92           
Flag Coverage Δ
unit 84.26% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf0d1b4...fc3a9df. Read the comment docs.

@per1234 per1234 merged commit 9477e68 into main Jan 13, 2021
@per1234 per1234 deleted the per1234/codecov branch January 13, 2021 02:00
@per1234 per1234 added topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement labels Sep 29, 2021
@per1234 per1234 self-assigned this Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants