Remove inappropriate element from paths filters of "Check Packaging" workflow #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…workflow The `on.*.paths` keys of GitHub workflows can be used to avoid unnecessary or unwanted workflow runs. This is done by defining specific paths containing files relevant to the workflow's purpose. The workflow will only run when the trigger event modifies a file matching the paths. The "Check Packaging" workflow was copied from another project that uses the Task task runner tool. In that project, it is appropriate for the workflow to be triggered on any change to the Task configuration file, and so it was added to the `paths` filter. This project uses npm instead of Task, and does not contain a taskfile, so the presence of that path in the filters is in appropriate and only adds unnecessary complexity to the workflow.
per1234
added
type: imperfection
umbynos
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
on.*.pathskeys of GitHub workflows can be used to avoid unnecessary or unwanted workflow runs. This is done bydefining specific paths containing files relevant to the workflow's purpose. The workflow will only run when the trigger
event modifies a file matching the paths.
The "Check Packaging" workflow was copied from another project that uses the Task task runner tool In that project, it is appropriate for the workflow to be triggered on any change to the Task configuration file, and so it was added to the
pathsfilter. This project uses npm instead of Task, and does not contain a taskfile, so the presence of that path in the filters is inappropriate and only adds unnecessary complexity to the workflow.