lib/msgpackrpc: Require a name when binding callables. #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iabdalkader
force-pushed
the
msgpackrpc_api_update
branch
2 times, most recently
from
1990f24 to
a660cb6
Compare
This change adds a required `name` argument to `MsgPackRPC.bind()` to avoid any ambiguity when binding multiple instances of the same class for example. Additionally, `bind()` now supports binding whole objects, by binding all of their public methods using their respective qualified names. Signed-off-by: iabdalkader <[email protected]>
iabdalkader
force-pushed
the
msgpackrpc_api_update
branch
from
a660cb6 to
932c256
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a required
nameargument toMsgPackRPC.bind()to avoid any ambiguity when binding multiple instances of the same class for example. Additionally,bind()now supports binding whole objects, by binding all of their public methods using their respective qualified names.