Send progress-end messages before shutting down #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required because the IDE does not correctly clean up resources once the language server is shutdown.
per1234
approved these changes
Jan 4, 2022
There was a problem hiding this comment.
When using versions of Arduino Language Server from the tip of the main branch (d3def8a) and earlier, I was able to cause the Arduino IDE 2.x to apparently hang in the "indexing" state by changing the board selection (and thus triggering a new indexing process) while an indexing process was in progress.
I am no longer able to reproduce that issue when using the build from this PR.
Great work Cristian!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
This is required because the IDE does not correctly clean up resources once the language server is shutdown.
The language server shutdown without any further message.
The language server sends a progress-end for any pending progress channel open.