Skip to content

Add flag to set cli config file #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2021
Merged

Add flag to set cli config file #77

merged 1 commit into from
Apr 19, 2021

Conversation

silvanocerza
Copy link
Contributor

Please check if the PR fulfills these requirements

  • What kind of change does this PR introduce?

Adds a new flag.

  • What is the current behavior?

When running the arduino-cli provided via the --cli flag the default config file is always used.

  • What is the new behavior?

Now the --cli-config flag must be set to point to a config file so the arduino-cli will be run using that configuration.

  • Other information:

None.

@silvanocerza silvanocerza requested a review from a team April 19, 2021 15:21
@silvanocerza silvanocerza self-assigned this Apr 19, 2021
@CLAassistant
Copy link

CLAassistant commented Apr 19, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

umbynos
umbynos approved these changes Apr 19, 2021
View reviewed changes
Copy link
Contributor

@umbynos umbynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏁

@silvanocerza silvanocerza merged commit 64a0e42 into main Apr 19, 2021
@silvanocerza silvanocerza deleted the scerza/config-flag branch April 19, 2021 15:37
@rsora rsora added the type: imperfection Perceived defect in any part of project label Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umbynos umbynos umbynos approved these changes

Assignees

@silvanocerza silvanocerza

Labels
type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@silvanocerza @CLAassistant @umbynos @rsora