Bump Windows runner version for build workflow #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatteoPologruto
added
topic: infrastructure
Previously, the 'windows-2016' runner was used for the Windows job used to build and test the application in the build GitHub Actions workflow. That runner has now been removed by GitHub. In its place, we will use the runner with the oldest version of Windows that is now available as a GitHub-hosted runner: 'windows-2019'. The reason for using the oldest available Windows version is to provide compatibility with the widest possible range of Windows versions for the users of the Arduino Language Server.
MatteoPologruto
force-pushed
the
update-windows-runner
branch
from
29f7e65 to
46bd823
Compare
umbynos
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
Bug fix
The
windows-2016runner is used for the Windows job used to build and test the application in the "build" GitHub Actions workflow. That runner has now been removed by GitHub. This causes the workflow runs to fail.Previously, the
windows-2016runner was used for the Windows job used to build and test the application in the build GitHub Actions workflow. That runner has now been removed by GitHub. In its place, we will use the runner with the oldest version of Windows that is now available as a GitHub-hosted runner:windows-2019.The reason for using the oldest available Windows version is to provide compatibility with the widest possible range of Windows versions for the users of the Arduino Language Server.