Skip to content

Added flag to disable real-time PublishDiagnostics push #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Jul 14, 2022

Please check if the PR fulfills these requirements

What kind of change does this PR introduce?
Add a flag to disable real-time diagnostics -no-real-time-diagnostics.

@cmaglie cmaglie requested review from kittaakos and umbynos and removed request for umbynos July 14, 2022 13:44
@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jul 15, 2022
kittaakos pushed a commit to kittaakos/vscode-arduino-tools that referenced this pull request Jul 15, 2022
kittaakos pushed a commit to kittaakos/vscode-arduino-tools that referenced this pull request Jul 15, 2022
@kittaakos
Copy link
Contributor

The functionality was verified here: arduino/arduino-ide#1107

Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cmaglie cmaglie merged commit dd92dd7 into main Jul 15, 2022
@cmaglie cmaglie deleted the flag_to_disable_real_time_errors branch July 15, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants