Skip to content

Clean up the properties callbacks upon disconnect #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/index.js
Original file line number Diff line number Diff line change
@@ -199,6 +199,21 @@ const disconnect = id => new Promise((resolve, reject) => {
}

client.disconnect();

// Remove property callbacks to allow resubscribing in a later connect()
Object.keys(propertyCallback).forEach((topic) => {
if (propertyCallback[topic]) {
delete propertyCallback[topic];
}
});

// Clean up subscribed topics - a new connection might not need the same topics
Object.keys(subscribedTopics).forEach((topic) => {
if (subscribedTopics[topic]) {
delete subscribedTopics[topic];
}
});

return resolve();
});