Skip to content

Let the wrapping Promise handle network errors thrown by getUserId #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 14, 2018
Merged

Let the wrapping Promise handle network errors thrown by getUserId #5

merged 1 commit into from
Dec 14, 2018

Conversation

xowor
Copy link
Collaborator

@xowor xowor commented Dec 14, 2018

Network errors thrown by the getUserId are thrown not rejected by the connect Promise.
Let this Promise handle them so they can be catched downstream.

@xowor xowor requested a review from eclipse1985 December 14, 2018 11:21
@CLAassistant
Copy link

CLAassistant commented Dec 14, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@eclipse1985 eclipse1985 merged commit fab5a27 into master Dec 14, 2018
@eclipse1985 eclipse1985 deleted the catch-getuserid-errors branch December 14, 2018 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eclipse1985 eclipse1985 Awaiting requested review from eclipse1985

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xowor @CLAassistant @eclipse1985