Set the current language on the localization provider #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
AlbyIanna
commented
Apr 15, 2022
Comment on lines
284
to
286
| if (currentLanguage === 'en') { | ||
| window.localStorage.removeItem(nls.localeId); | ||
| } else { |
There was a problem hiding this comment.
@kittaakos do you think it's necessary to save the locale id to the local storage like this in order for the localization to work?
I thought that setting the current language to the localization provider was enough, so I've tried removing this code, but then the localization didn't work correctly, therefore it appears it is not enough.
per1234
added
topic: code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The English language gets forgotten when changing the language.
Solves #956
Change description
Set the language to the localization provider
Other information
Reviewer checklist