Skip to content

Use electron reload command when changing language #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2022
Merged

Use electron reload command when changing language #953

merged 1 commit into from
Apr 14, 2022

Conversation

AlbyIanna
Copy link
Contributor

@AlbyIanna AlbyIanna commented Apr 13, 2022 •
edited by fstasi
Loading

Motivation

Attempt to solve #948

fixes #948

Change description

Execute the command ElectronCommands.RELOAD instead of running calling window.location.reload();

Other information

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@AlbyIanna AlbyIanna requested a review from per1234 April 13, 2022 14:36
@AlbyIanna AlbyIanna changed the title use electron reload command when changing language Use electron reload command when changing language Apr 13, 2022
per1234
per1234 approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solves #948 for me.

In addition to testing that the IDE now behaves as expected on "Language" preference change on Windows, I also tested on Ubuntu 20.04 to verify that the "Language" preference change continues to work as it did before (I only experienced #948 on Windows).

Thanks Alberto!

@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Apr 13, 2022
@AlbyIanna AlbyIanna merged commit a3640cf into main Apr 14, 2022
@AlbyIanna AlbyIanna deleted the fix-reload branch April 14, 2022 07:38
@per1234 per1234 mentioned this pull request Apr 14, 2022
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IDE hangs after changing "Language" preference
2 participants
@AlbyIanna @per1234