Skip to content

Correctly print backslash-escaped characters #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 6, 2022
Merged

Correctly print backslash-escaped characters #943

merged 1 commit into from
Apr 6, 2022

Conversation

AlbyIanna
Copy link
Contributor

@AlbyIanna AlbyIanna commented Apr 5, 2022 •
edited by fstasi
Loading

Motivation

When printing output to the serial monitor, some characters are not being rendered as expected. For example, tabs are rendered like normal whitespaces (#675). This is caused by how HTML treats these kinds of characters.

Change description

Wrap each serial monitor message inside a <pre> element.

fixes #675

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@AlbyIanna AlbyIanna requested review from fstasi and per1234 April 5, 2022 09:30
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project topic: serial monitor Related to the Serial Monitor labels Apr 6, 2022
@per1234 per1234 linked an issue Apr 6, 2022 that may be closed by this pull request
Serial Monitor swallowing leading and repeated spaces #535
Closed
per1234
per1234 approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes #535 and #675 for me.
Thanks @AlbyIanna!

@AlbyIanna AlbyIanna merged commit aba9db6 into main Apr 6, 2022
@AlbyIanna AlbyIanna deleted the monitor-tabs branch April 6, 2022 16:05
@per1234 per1234 mentioned this pull request Jun 22, 2022
Closed
@per1234 per1234 mentioned this pull request Aug 5, 2022
Closed
3 tasks
@Belinus-code
Copy link

Belinus-code commented Oct 11, 2022 •
edited
Loading

Hey, could you do an example how to "Wrap each serial monitor message inside a pre element"?
I'm not getting this.
Thanks

@arduino arduino locked as resolved and limited conversation to collaborators Oct 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@per1234 per1234 per1234 approved these changes

@fstasi fstasi Awaiting requested review from fstasi

Assignees

@ubidefeo ubidefeo

Labels
topic: code Related to content of the project itself topic: serial monitor Related to the Serial Monitor type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
4 participants
@AlbyIanna @Belinus-code @per1234 @ubidefeo