Skip to content

Fix generation of update channel files in CI #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Conversation

AlbyIanna
Copy link
Contributor

Motivation

The process that generates the updater channel files is broken in the CI

Change description

Move the renaming of the channel files (beta*.yml and latest*.yml into nightly*.yml and stable*.yml) inside the electron packager script.

Other information

Apparently, electron-builder doesn't allow custom channels, so the only channels available are alpha, beta and latest. Since we want to use different channel names (stable and nightly) we need to rename the channel files after the packaging of the app.

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@AlbyIanna AlbyIanna merged commit 77b4306 into main Feb 17, 2022
@AlbyIanna AlbyIanna deleted the fix-updater-ci branch February 17, 2022 09:29
@per1234 per1234 added topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project labels Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants