Skip to content

Prevent from pushing files that are bigger than 100 KB #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 15 commits into from

Conversation

AlbyIanna
Copy link
Contributor

Why

Solves #634

How

When calling recursiveURIs in getUrisMap I return an empty array when I find a file that is bigger than 100 KB.

# Conflicts:
#	arduino-ide-extension/package.json
#	arduino-ide-extension/src/browser/arduino-ide-frontend-module.ts
#	arduino-ide-extension/src/browser/monitor/monitor-connection.ts
#	arduino-ide-extension/src/browser/serial/monitor/monitor-view-contribution.tsx
#	arduino-ide-extension/src/browser/serial/monitor/monitor-widget.tsx
#	arduino-ide-extension/src/test/browser/boards-auto-installer.test.ts
# Conflicts:
#	arduino-ide-extension/src/browser/boards/boards-config.tsx
# Conflicts:
#	arduino-ide-extension/src/browser/arduino-ide-frontend-module.ts
#	arduino-ide-extension/src/browser/contributions/upload-sketch.ts
# Conflicts:
#	arduino-ide-extension/src/browser/dialogs/settings/settings-component.tsx
@AlbyIanna AlbyIanna requested review from fstasi and ubidefeo November 29, 2021 14:25
Base automatically changed from theia-1.19 to main November 29, 2021 14:54
@per1234 per1234 linked an issue Nov 30, 2021 that may be closed by this pull request
@per1234 per1234 added the topic: code Related to content of the project itself label Dec 23, 2021
@per1234
Copy link
Contributor

per1234 commented Dec 23, 2021

@AlbyIanna was this superseded by #696?

@AlbyIanna
Copy link
Contributor Author

@AlbyIanna was this superseded by #696?

@per1234 yes it was. Closing this one

@AlbyIanna AlbyIanna closed this Mar 21, 2022
@per1234 per1234 added the conclusion: invalid Issue/PR not valid label Mar 21, 2022
@per1234 per1234 deleted the fix-big-file-push branch June 27, 2022 23:18
@per1234 per1234 added the type: imperfection Perceived defect in any part of project label Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: invalid Issue/PR not valid topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Large file crashes IDE when pushing to Remote Sketchbook
3 participants