Skip to content

Remove language server log preference #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Remove language server log preference #635

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 0 additions & 29 deletions arduino-ide-extension/src/browser/settings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ const WINDOW_SETTING = `${ARDUINO_SETTING}.window`;
// const IDE_SETTING = `${ARDUINO_SETTING}.ide`;
const COMPILE_SETTING = `${ARDUINO_SETTING}.compile`;
const UPLOAD_SETTING = `${ARDUINO_SETTING}.upload`;
const LANGUAGE_SETTING = `${ARDUINO_SETTING}.language`;
const SKETCHBOOK_SETTING = `${ARDUINO_SETTING}.sketchbook`;
const AUTO_SCALE_SETTING = `${WINDOW_SETTING}.autoScale`;
const ZOOM_LEVEL_SETTING = `${WINDOW_SETTING}.zoomLevel`;
Expand All @@ -53,7 +52,6 @@ const COMPILE_VERBOSE_SETTING = `${COMPILE_SETTING}.verbose`;
const COMPILE_WARNINGS_SETTING = `${COMPILE_SETTING}.warnings`;
const UPLOAD_VERBOSE_SETTING = `${UPLOAD_SETTING}.verbose`;
const UPLOAD_VERIFY_SETTING = `${UPLOAD_SETTING}.verify`;
const LANGUAGE_LOG_SETTING = `${LANGUAGE_SETTING}.log`;
const SHOW_ALL_FILES_SETTING = `${SKETCHBOOK_SETTING}.showAllFiles`;

export interface Settings extends Index {
Expand All @@ -69,7 +67,6 @@ export interface Settings extends Index {
compilerWarnings: CompilerWarnings; // `arduino.compile.warnings`
verboseOnUpload: boolean; // `arduino.upload.verbose`
verifyAfterUpload: boolean; // `arduino.upload.verify`
enableLsLogs: boolean; // `arduino.language.log`
sketchbookShowAllFiles: boolean; // `arduino.sketchbook.showAllFiles`

sketchbookPath: string; // CLI
Expand Down Expand Up @@ -127,7 +124,6 @@ export class SettingsService {
compilerWarnings,
verboseOnUpload,
verifyAfterUpload,
enableLsLogs,
sketchbookShowAllFiles,
cliConfig,
] = await Promise.all([
Expand All @@ -151,7 +147,6 @@ export class SettingsService {
this.preferenceService.get<any>(COMPILE_WARNINGS_SETTING, 'None'),
this.preferenceService.get<boolean>(UPLOAD_VERBOSE_SETTING, true),
this.preferenceService.get<boolean>(UPLOAD_VERIFY_SETTING, true),
this.preferenceService.get<boolean>(LANGUAGE_LOG_SETTING, true),
this.preferenceService.get<boolean>(SHOW_ALL_FILES_SETTING, false),
this.configService.getConfiguration(),
]);
Expand All @@ -169,7 +164,6 @@ export class SettingsService {
compilerWarnings,
verboseOnUpload,
verifyAfterUpload,
enableLsLogs,
sketchbookShowAllFiles,
additionalUrls,
sketchbookPath,
Expand Down Expand Up @@ -249,7 +243,6 @@ export class SettingsService {
compilerWarnings,
verboseOnUpload,
verifyAfterUpload,
enableLsLogs,
sketchbookPath,
additionalUrls,
network,
Expand Down Expand Up @@ -315,11 +308,6 @@ export class SettingsService {
verifyAfterUpload,
PreferenceScope.User
),
this.preferenceService.set(
LANGUAGE_LOG_SETTING,
enableLsLogs,
PreferenceScope.User
),
this.preferenceService.set(
SHOW_ALL_FILES_SETTING,
sketchbookShowAllFiles,
Expand Down Expand Up @@ -581,17 +569,6 @@ export class SettingsComponent extends React.Component<
'Editor Quick Suggestions'
)}
</label>
<label className="flex-line">
<input
type="checkbox"
checked={this.state.enableLsLogs}
onChange={this.enableLsLogsDidChange}
/>
{nls.localize(
'arduino/preferences/languageServerLogging',
'Enable language server logging'
)}
</label>
<div className="flex-line">
{nls.localize(
'arduino/preferences/additionalManagerURLs',
Expand Down Expand Up @@ -814,12 +791,6 @@ export class SettingsComponent extends React.Component<
this.setState({ autoScaleInterface: event.target.checked });
};

protected enableLsLogsDidChange = (
event: React.ChangeEvent<HTMLInputElement>
) => {
this.setState({ enableLsLogs: event.target.checked });
};

protected interfaceScaleDidChange = (
event: React.ChangeEvent<HTMLInputElement>
) => {
Expand Down