Implement unit tests for boards-auto-installer #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlbyIanna
force-pushed
the
unit-tests
branch
from
1186b85 to
ee09b64
Compare
fstasi
suggested changes
Sep 23, 2021
Comment on lines
-109
to
+108
| if (answer) { | ||
| if (answer === 'Install Manually') { |
There was a problem hiding this comment.
this change is suspicious and not test related. Did we mess up with commits?
There was a problem hiding this comment.
No, I changed this on purpose. In the current implementation, we are checking if the answer is 'Yes': if so, we install the library; in any other case, we open the library manager. I didn't like that, because if we'd add another answer like 'Nah, I don't want to', we don't want to open it.
AlbyIanna
force-pushed
the
unit-tests
branch
2 times, most recently
from
93f3e60 to
98f034e
Compare
AlbyIanna
force-pushed
the
unit-tests
branch
from
98f034e to
d1f3aaf
Compare
per1234
added
topic: infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first step for enabling us to implement unit tests on the frontend. Simply run
yarn test😄We decided to use typemoq in order to mock our injectable services.
While doing the tests, we noticed the
ResponseServicewere not being injected correctly as we were injectingResponseServiceImpldirectly and this was causing troubles, so we created a new interfaceResponseServiceArduino.