Skip to content

[ATL-493] Support platforms installed in directories.user #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2021
Merged

[ATL-493] Support platforms installed in directories.user #473

merged 1 commit into from
Aug 23, 2021

Conversation

AlbyIanna
Copy link
Contributor

Add {in Sketchbook) label to manually installed board packages.
Should solve #126

@AlbyIanna AlbyIanna requested a review from fstasi August 11, 2021 11:35
@AlbyIanna AlbyIanna changed the title Support platforms installed in directories.user [ATL-493] Support platforms installed in directories.user Aug 11, 2021
ubidefeo
ubidefeo approved these changes Aug 18, 2021
View reviewed changes
Copy link

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested and it works as expected.
I have also asked @facchinm to try it out and let us know if it works for his workflows

LGTM

@fstasi fstasi merged commit 6233e1f into main Aug 23, 2021
@fstasi fstasi deleted the atl-493--manually-installed-libraries branch August 23, 2021 08:47
@per1234
Copy link
Contributor

per1234 commented Oct 28, 2021

Should solve #126

I don't think this is accurate because my investigations indicate that the issues reported in #126 were fixed long before (that issue just wasn't closed at that time):

  • The Boards Manager shows them as boards package an offers INSTALL.
  • the custom boards can't be selected in Select Board

If I understand correctly, this PR doesn't address either of those things. Instead, it is about adding the very useful "(in Sketchbook)" suffix to the entries for sketchbook installed platforms in the Tools > Board menu.

@per1234 per1234 added the topic: code Related to content of the project itself label Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fstasi fstasi fstasi approved these changes

@ubidefeo ubidefeo ubidefeo approved these changes

@facchinm facchinm facchinm approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AlbyIanna @per1234 @fstasi @ubidefeo @facchinm