Skip to content

[ATL-1435] Force some files to be read-only #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2021
Merged

[ATL-1435] Force some files to be read-only #453

merged 1 commit into from
Jul 23, 2021

Conversation

AlbyIanna
Copy link
Contributor

WHY

We need to force some files ("thingProperties.h") to be read-only, even if they are downloaded on the user's machine

HOW

Use an array of read-only files and add a simple check in the isReadOnly() function.

@AlbyIanna AlbyIanna requested a review from fstasi July 14, 2021 10:21
@AlbyIanna AlbyIanna force-pushed the atl-1435--make-thingProperties.h-readonly branch from 6ee52aa to 18ea23e Compare July 22, 2021 12:54
@AlbyIanna AlbyIanna merged commit 38d372e into main Jul 23, 2021
@fstasi fstasi deleted the atl-1435--make-thingProperties.h-readonly branch July 23, 2021 13:00
@per1234 per1234 added topic: code Related to content of the project itself type: enhancement Proposed improvement labels Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fstasi fstasi fstasi approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlbyIanna @fstasi @per1234