Fix url to open sketch in cloud editor #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fstasi
approved these changes
Jul 15, 2021
AlbyIanna
force-pushed
the
atl-1432-url-to-open-sketch-in-webide-is-wrong
branch
from
aac7d33 to
16ba1a2
Compare
per1234
added
topic: code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
When opening a sketch in the Cloud editor through the contextual menu in the Remote Sketchbook, the user is redirected to the wrong URL.
It should link to: “create.arduino.cc/[USERNAME]/[SKETCH_ID]”
But right now it links to: “create.arduino.cc/[SKETCH_ID]”
Which results in the editor opening the first sketch in the list
HOW
Pass the username as an argument when executing the command to open the contextual menu.