Refactor Init process to use new CLI gRPC API #342
Conversation
| @@ -26,6 +26,7 @@ export class CoreServiceImpl extends CoreClientAware implements CoreService { | |||
| const { sketchUri, fqbn, compilerWarnings } = options; | |||
| const sketchPath = FileUri.fsPath(sketchUri); | |||
|
|
|||
| await this.coreClientProvider.initialized; | |||
There was a problem hiding this comment.
@silvanocerza what happens if the initialized fails or rejects? is it ok to proceed calling coreClient()?
There was a problem hiding this comment.
I think it's fine, if the Init gRPC function fails it means it has been called, so Create was successful meaning we have an internal instance in the CLI daemon and we have a "working" client.
If Init fails completely though we must have some other huge problems, with the refactoring failure to load a platform or library just logs an error, but it doesn't stop completely.
I still don't like how I implemented this though, I'd like to show the user a notification when there are this kind of failures but am not sure how to handle that.
silvanocerza
force-pushed
the
scerza/new-init-process
branch
2 times, most recently
from
e6e139d to
f73f321
Compare
|
@silvanocerza
|
|
@ubidefeo I investigated a bit, the same issue is also present when uninstalling a library. It seems to me this is a race condition, the list of boards divided by platform is retrieved before the platform is uninstalled, the strange thing though is that after installing a new one I'd expect it to stop showing the uninstalled platform but it doesn't. 🤔 This requires some further investigation I guess. |
silvanocerza
force-pushed
the
scerza/new-init-process
branch
from
b6b1073 to
178a11d
Compare
|
Rebased to fix conflicts and trigger a new build after updating the version of the Arduino CLI. |
fstasi
force-pushed
the
scerza/new-init-process
branch
from
be4546b to
178a11d
Compare
silvanocerza
force-pushed
the
scerza/new-init-process
branch
from
178a11d to
13de2f8
Compare
|
This has been superseded by #506. Closing. |
per1234
added
conclusion: duplicate
The CLI initialization process has been changed in significant ways with PR arduino/arduino-cli#1274, it needs to be thorougly tested before merging to avoid breaking the IDE.