Skip to content

ATL-372: .ino file associations #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

ATL-372: .ino file associations #293

wants to merge 1 commit into from

Conversation

fstasi
Copy link
Contributor

@fstasi fstasi commented Mar 31, 2021 •
edited
Loading

Motivation

We want to add 2 functionalities to the ide

  • associate a file type (namely, .ino files)
  • allow the drag and drop of a file over the icon (macOS only) and open the relevant files

Change description

DRAFT: the following changes are just a proposal;

  • file association is done via electronBuilder + template-package.json configuration
  • files to be opened are handled in electron-main-applicatoin.ts

Additional Notes

See comments in the attached Jira Task

Reviewer checklist

  • PR address a single concern.
  • PR title and description are properly filled.
  • History is clean, commit messages are meaningful.

@fstasi fstasi force-pushed the atl-372--file-association branch from c8c8f4e to b1fa180 Compare March 31, 2021 12:25
@CLAassistant
Copy link

CLAassistant commented Apr 9, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@per1234
Copy link
Contributor

per1234 commented May 25, 2021 •
edited
Loading

Related:

@rsora rsora added the topic: code Related to content of the project itself label Oct 25, 2021
@rsora rsora added the priority: high Resolution is a high priority label Oct 25, 2021
@rsora rsora added criticality: high Of high impact and removed priority: high Resolution is a high priority labels Nov 2, 2021
@fstasi fstasi linked an issue Jan 19, 2022 that may be closed by this pull request
Missing support for "open with" and file association #757
Closed
@fstasi fstasi removed their assignment Jan 25, 2022
@fstasi
Copy link
Contributor Author

fstasi commented Jan 25, 2022

Assigned to Mark

@fstasi fstasi assigned fstasi and unassigned AlbyIanna Jan 25, 2022
@msujew msujew mentioned this pull request Feb 14, 2022
Merged
@fstasi fstasi closed this in #835 Feb 23, 2022
@per1234 per1234 added the conclusion: duplicate Has already been submitted label Feb 23, 2022
@per1234 per1234 deleted the atl-372--file-association branch May 4, 2022 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fstasi fstasi

Labels
conclusion: duplicate Has already been submitted criticality: high Of high impact topic: code Related to content of the project itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing support for "open with" and file association
5 participants
@fstasi @CLAassistant @per1234 @AlbyIanna @rsora