Possible Fix for Issue 2036 #2717
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Title: Custom board option menus not following the order sent by the cli
Fixes "Custom board option menus not following the order inside boards.txt"
Line 74-76 of "boards-data-menu-updater.ts":
for (const { label, option, values } of configOptions.sort(
ConfigOption.LABEL_COMPARATOR
)) {
New Line 74:
for (const { label, option, values } of configOptions ) {
IMHO using sort on configOptions will produce the mentioned failure.
Simply don't sort and the order will be as in Arduino IDE 1.x (as desfined inside board.txt)
I don't have the tools to build and test this change.
I use the AppImage "arduino-ide_2.3.6_Linux_64bit.AppImage"
Signed-off-by: Günter Neiß <[email protected]>
|
|
Signed-off-by: Günter Neiß <[email protected]>
|
@per1234 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 2036, Title: Custom board option menus not following the order sent by the cli
Fixes "Custom board option menus not following the order inside boards.txt"
Line 74-76 of "boards-data-menu-updater.ts":
for (const { label, option, values } of configOptions.sort(
ConfigOption.LABEL_COMPARATOR
)) {
New Line 74:
for (const { label, option, values } of configOptions ) {
IMHO using sort on configOptions will produce the mentioned failure. Simply don't sort and the order will be as in Arduino IDE 1.x (as defined inside board.txt)
I don't have the tools to build and test this change. I use the AppImage "arduino-ide_2.3.6_Linux_64bit.AppImage"
Reviewer checklist