ATL-1128: make the new tab button easier to click #258
Conversation
@ubidefeo this issue should be unrelated, plus, I'm not able to reproduce it. Did you resize the window or moved to another virtual desktop? @kittaakos did you see this issue before? |
|
I have experienced the same, which was related to changing the interface scale (see ATL-1080). @ubidefeo do you have any modifications to the File > Preferences > Interface Scale setting? |
No, I have not but the issue must be either somewhere here: or was already fixed in Theia: eclipse-theia/theia#9082. Maybe, there is nothing to do other than updating to the most recent |
let's address this in a separate PR then, thanks |
fstasi
force-pushed
the
atl-1128--tab-button
branch
from
84603a2 to
a8df82e
Compare
|
@kittaakos @fstasi |
I would do the followings:
|
|
looks like a good plan
hope it works :)
ubi
… On 25 Mar 2021, at 16:51, Akos Kitta ***@***.***> wrote:
what should be done for this one, then?
I would do the followings:
rebase #231 and merge if it was approved,
rebase this PR from main, start a build see if the context menu bug still occurs.
If no, we're good. The issue has been fixed in Theia. We can merge this PR.
If yes, we need to fix it either as a follow-up or with this PR.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Can you please rebase the PR from the diff --git a/arduino-ide-extension/src/browser/contributions/sketch-control.ts b/arduino-ide-extension/src/browser/contributions/sketch-control.ts
index 6e4010c..db0aa48 100644
--- a/arduino-ide-extension/src/browser/contributions/sketch-control.ts
+++ b/arduino-ide-extension/src/browser/contributions/sketch-control.ts
@@ -6,6 +6,7 @@ import { ContextMenuRenderer } from '@theia/core/lib/browser/context-menu-render
import { Disposable, DisposableCollection } from '@theia/core/lib/common/disposable';
import { URI, SketchContribution, Command, CommandRegistry, MenuModelRegistry, KeybindingRegistry, TabBarToolbarRegistry, open } from './contribution';
import { ArduinoMenus } from '../menu/arduino-menus';
+import { EditorWidget } from '@theia/editor/lib/browser';
@injectable()
export class SketchControl extends SketchContribution {
@@ -24,15 +25,28 @@ export class SketchControl extends SketchContribution {
registerCommands(registry: CommandRegistry): void {
registry.registerCommand(SketchControl.Commands.OPEN_SKETCH_CONTROL__TOOLBAR, {
isVisible: widget => this.shell.getWidgets('main').indexOf(widget) !== -1,
- execute: async () => {
+ execute: async widget => {
this.toDisposeBeforeCreateNewContextMenu.dispose();
const sketch = await this.sketchServiceClient.currentSketch();
if (!sketch) {
return;
}
+ let target: HTMLElement | undefined = undefined;
+ if (widget instanceof EditorWidget) {
+ const tabBar = this.shell.getTabBarFor(widget);
+ if (tabBar) {
+ const elements = document.querySelectorAll(`#${SketchControl.Commands.OPEN_SKETCH_CONTROL__TOOLBAR.id}`);
+ for (const element of Array.from(elements)) {
+ if (!target) {
+ if (tabBar.node.contains(element)) {
+ target = element as HTMLElement;
+ }
+ }
+ }
+ }
+ }
- const target = document.getElementById(SketchControl.Commands.OPEN_SKETCH_CONTROL__TOOLBAR.id);
- if (!(target instanceof HTMLElement)) {
+ if (!target) {
return;
}
const { parentElement } = target;
|
The active area for the new tab button is very small.
This PR expands the active area by moving the padding from the container of the button to the button itself.
Padding changed because of the actual size of the chevron icon in the button.
Fixes #97
Jira Task