-
-
Notifications
You must be signed in to change notification settings - Fork 431
ATL-1118: Add keymaps customization support #231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0fd31ea
to
ecff615
Compare
ecff615
to
35ee1dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works nicely and the code looks good 👍
Please wait for another verification before the merge. Thanks!
arduino-ide-extension/src/browser/theia/keymaps/keymaps-frontend-contribution.ts
Outdated
Show resolved
Hide resolved
arduino-ide-extension/src/browser/theia/keymaps/keymaps-frontend-contribution.ts
Outdated
Show resolved
Hide resolved
arduino-ide-extension/src/browser/theia/keymaps/keymaps-frontend-contribution.ts
Outdated
Show resolved
Hide resolved
arduino-ide-extension/src/browser/theia/keymaps/keymaps-frontend-contribution.ts
Outdated
Show resolved
Hide resolved
35ee1dd
to
6de67b5
Compare
adding @ubidefeo for a double check before merging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have only one problem with this, and it's the placement of the key-bindings as a sub-menu of "preferences".
Historically the IDE preferences menu item served as an item, not a container of sub-options.
When a new user reads "go to ... > preferences" they won't know wether settings or key-bindings is the place to go.
@giannicolab @per1234 what's your take on this?
My concern with the new menu structure is that it breaks all the documentation/tutorials/etc. that tell people to open File > Preferences. My preference would be to have the keyboard shortcut editor accessed via the File > Preferences dialog. But I'm guessing this is simply not technically feasible. So I'm thinking the best approach is to leave the File > Preferences menu path alone and add a new menu item for the keyboard shortcuts. I think it's really nice to have configurable keyboard shortcuts. This is a feature I always look for in the applications I use. |
6de67b5
to
f366405
Compare
@per1234 @giannicolab @ubidefeo updated as below |
f366405
to
033fad0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Francesco!
The default keybindings may be reasonable for beginners, but PRO users expect the keybindings to be customizable, as they are in other editors.
In this PR:
theia/keymap
packages that let users change the default keybindings to their preference (see image below)(window version)
