Skip to content

Removed the min window height and width. #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 31, 2021
Merged

Conversation

kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Mar 19, 2021

Made the boards config dialog slightly smaller.

Closes #216.
Closes #96.

Signed-off-by: Akos Kitta [email protected]

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really a great improvement.

I did encounter a problem though: If you have the package index URL for the popular 3rd party "DrAzzy" boards platforms in your preferences, but no installation of the ATTinyCore platform it provides, the "Ports" menu disappears from the "Select Other Board & Port" dialog:
Clipboard01

Notice that DrAzzy has made some creative usage of the package index's packages[].platforms[].boards field:

"boards": [
  {
    "name": "<b>Program via ISP or Serial:</b> ATtiny841/441, ATtiny85/45/25, ATtiny84/44/24, ATtiny1634, ATtiny861/461/261, ATtiny167/87, ATtiny43, ATtiny828, ATtiny88/48, ATtiny4313/2313"
  },
  {
    "name": "<br/><b>USB (Micronucleus) Support:</b> DigiSpark (t85), Digispark Pro (t167), MH-ET (t88), Wattuino/Nanite/etc (t841), CaliforniaSTEAM (t84)"
  },
  {
    "name": "<br/><b>Windows users:</b> If USB drivers are not already installed, run the post_install.bat manually or DL from <a href=https://azduino.com/bin/micronucleus>https://azduino.com/bin/micronucleus</a>"
  }
],

Steps to reproduce

  1. (In Arduino IDE) Select File > Preferences from the menus.
  2. Add the following URL to the "Additional Boards Manager URLs" field: http://drazzy.com/package_drazzy.com_index.json (separate with comma if there are multiple URLs in the field).
  3. Click the "OK" button.
  4. Close the Arduino IDE.
  5. Start the Arduino IDE
  6. Click the drop down board selection menu in the button tool bar.
  7. From the menu, click on "Select Other Board & Port" - There is no "Ports" menu in the dialog that opens.

Note that you must not have the ATTinyCore boards platform installed. If you have it installed, do an uninstallation before restarting the IDE. The reason is that the IDE only uses the strings from the packages[].platforms[].boards field when the platform is not installed. After installation, it uses the board name strings from boards.txt instead, which are different in the case of ATTinyCore.

This issue does not occur with Arduino IDE 2.0.0-beta.4

I was able to reproduce this on both Windows and Linux machines.

@ubidefeo
Copy link

@per1234
since it does not occur on Beta 4, shouldn't we declare this solved?

@per1234
Copy link
Contributor

per1234 commented Mar 23, 2021

@ubidefeo no. The fact that the issue I reported does not occur in 2.0.0-beta.4 proves that it was introduced by this PR.

@ubidefeo
Copy link

@per1234
Oh, right!
my synapses got crossed there.
thanks 👍🏼

@kittaakos
Copy link
Contributor Author

I reported does not occur in 2.0.0-beta.4

I can reproduce it with beta.4. Although the ports are still visible, the layout is broken. Anyways, I will fix it as part of this PR.

screencast 2021-03-29 13-14-25

Akos Kitta added 4 commits March 29, 2021 16:06
Made the boards config dialog slightly smaller.

Closes #216.

Signed-off-by: Akos Kitta <[email protected]>
Instead of adding an empty string URL, we add nothing.

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos force-pushed the arduino/arduino-ide#216 branch from 5e6725d to ca109de Compare March 29, 2021 14:06
@kittaakos
Copy link
Contributor Author

I have updated the dialog stylings. I hope it provides a somewhat better UX. Could you please take another look, Per? Thank you!

screencast.2021-03-29.16-13-40.mp4

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great for me now. I was personally affected by the previous minimum window dimensions because my supplemental laptop's display is smaller than what was necessary to provide for easy usage of the IDE.

Thanks Akos!

@kittaakos kittaakos merged commit 9867122 into main Mar 31, 2021
@kittaakos kittaakos deleted the arduino/arduino-ide#216 branch March 31, 2021 11:47
@per1234 per1234 added the topic: code Related to content of the project itself label Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to shrink IDE window. [UX] The board select dialog is broken when the window size is small
3 participants