-
-
Notifications
You must be signed in to change notification settings - Fork 433
Removed the min window height and width. #243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really a great improvement.
I did encounter a problem though: If you have the package index URL for the popular 3rd party "DrAzzy" boards platforms in your preferences, but no installation of the ATTinyCore platform it provides, the "Ports" menu disappears from the "Select Other Board & Port" dialog:
Notice that DrAzzy has made some creative usage of the package index's packages[].platforms[].boards
field:
"boards": [
{
"name": "<b>Program via ISP or Serial:</b> ATtiny841/441, ATtiny85/45/25, ATtiny84/44/24, ATtiny1634, ATtiny861/461/261, ATtiny167/87, ATtiny43, ATtiny828, ATtiny88/48, ATtiny4313/2313"
},
{
"name": "<br/><b>USB (Micronucleus) Support:</b> DigiSpark (t85), Digispark Pro (t167), MH-ET (t88), Wattuino/Nanite/etc (t841), CaliforniaSTEAM (t84)"
},
{
"name": "<br/><b>Windows users:</b> If USB drivers are not already installed, run the post_install.bat manually or DL from <a href=https://azduino.com/bin/micronucleus>https://azduino.com/bin/micronucleus</a>"
}
],
Steps to reproduce
- (In Arduino IDE) Select File > Preferences from the menus.
- Add the following URL to the "Additional Boards Manager URLs" field:
http://drazzy.com/package_drazzy.com_index.json
(separate with comma if there are multiple URLs in the field). - Click the "OK" button.
- Close the Arduino IDE.
- Start the Arduino IDE
- Click the drop down board selection menu in the button tool bar.
- From the menu, click on "Select Other Board & Port" - There is no "Ports" menu in the dialog that opens.
Note that you must not have the ATTinyCore boards platform installed. If you have it installed, do an uninstallation before restarting the IDE. The reason is that the IDE only uses the strings from the packages[].platforms[].boards
field when the platform is not installed. After installation, it uses the board name strings from boards.txt instead, which are different in the case of ATTinyCore.
This issue does not occur with Arduino IDE 2.0.0-beta.4
I was able to reproduce this on both Windows and Linux machines.
@per1234 |
@ubidefeo no. The fact that the issue I reported does not occur in 2.0.0-beta.4 proves that it was introduced by this PR. |
@per1234 |
Made the boards config dialog slightly smaller. Closes #216. Signed-off-by: Akos Kitta <[email protected]>
Signed-off-by: Akos Kitta <[email protected]>
Instead of adding an empty string URL, we add nothing. Signed-off-by: Akos Kitta <[email protected]>
Signed-off-by: Akos Kitta <[email protected]>
5e6725d
to
ca109de
Compare
I have updated the dialog stylings. I hope it provides a somewhat better UX. Could you please take another look, Per? Thank you! screencast.2021-03-29.16-13-40.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great for me now. I was personally affected by the previous minimum window dimensions because my supplemental laptop's display is smaller than what was necessary to provide for easy usage of the IDE.
Thanks Akos!
Made the boards config dialog slightly smaller.
Closes #216.
Closes #96.
Signed-off-by: Akos Kitta [email protected]