Skip to content

fix: board <select> update on board detach #2291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2024
Merged

fix: board <select> update on board detach #2291

merged 1 commit into from
Jan 15, 2024

Conversation

kittaakos
Copy link
Contributor

Motivation

When the previously selected board is not detected, unset the <select> option.

Closes #2222

Change description

Other information

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

fix: board <select> update on board detach
e1dd588 
When the previously selected board is not detected, unset the `<select>`
option.

Closes #2222

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Nov 22, 2023
@kittaakos kittaakos requested a review from per1234 November 22, 2023 15:34
davegarthsimpson
davegarthsimpson approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@davegarthsimpson davegarthsimpson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kittaakos kittaakos merged commit 0ca1a31 into main Jan 15, 2024
@kittaakos kittaakos deleted the #2222 branch January 15, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davegarthsimpson davegarthsimpson davegarthsimpson approved these changes

@per1234 per1234 Awaiting requested review from per1234

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Previous selection remains in Firmware Updater and Certificate Uploader menu after no longer available
2 participants
@kittaakos @davegarthsimpson