Skip to content

fix: can open IDE2 from an ino file #2288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2024
Merged

fix: can open IDE2 from an ino file #2288

merged 1 commit into from
Jan 15, 2024

Conversation

kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Nov 20, 2023

Motivation

Can open IDE2 from an ino file.

Change description

Use a fallback frontend app config when starting IDE2 from an ino file
(from Explorer, Finder, etc.) and the app config is not yet set.

Other information

See the Beta Testing Guide on how to verify the changes.

Preconditions:

  • make sure the tester build is your default app to open ino files (On macOS, I had to wipe all previous IDE2 versions)

Steps to verify:

  • download the tester build,
  • start the IDE2 from its app icon (it starts),
  • open more than one sketch and quit,
  • start the IDE2 from its app icon (it starts, all previously opened (saved!) sketch windows open),
  • quit IDE,
  • open IDE2 by double clicking on an ino file (in Explorer, Finder, etc.) (it opens the sketch),
  • quit IDE,
  • start the IDE2 from a command line: for example /Applications/Arduino\ IDE.app/Contents/MacOS/Arduino\ IDE ~/Documents/Arduino/hello on macOS (it opens the hello sketch).

Closes #2209

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Nov 20, 2023
@kittaakos kittaakos marked this pull request as draft November 20, 2023 17:00
Use a fallback frontend app config when starting IDE2 from an ino file
(from Explorer, Finder, etc.) and the app config is not yet set.

Closes #2209

Signed-off-by: Akos Kitta <[email protected]>
Copy link
Contributor

@davegarthsimpson davegarthsimpson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@kittaakos kittaakos merged commit 3eef857 into main Jan 15, 2024
@kittaakos kittaakos deleted the #2209 branch January 15, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Double clicking any .ino file won't open IDE window
2 participants