Skip to content

GH-10: Serial monitor should spare WS connection. #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2021
Merged

GH-10: Serial monitor should spare WS connection. #22

merged 1 commit into from
Feb 17, 2021

Conversation

kittaakos
Copy link
Contributor

Closes #10.

Signed-off-by: Akos Kitta [email protected]

@kittaakos kittaakos requested review from ubidefeo and rsora February 15, 2021 14:15
@kittaakos
Copy link
Contributor Author

This PR contains the bare-minimum changeset to fix the non-responsive app issue when the serial-monitor sends excessive data. This PR does not change anything in the UI, only how the client communicates with the serial-monitor. Please verify. Thank you!

per1234
per1234 approved these changes Feb 15, 2021
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to reproduce #10 before this change, and cannot reproduce it after this change.

ubidefeo
ubidefeo approved these changes Feb 16, 2021
View reviewed changes
Copy link

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a temporary fix this helps a lot.
I did not have trouble using the compile or upload functionality.
Output in the window gets a bit laggy at times, but at least this allows users to work with it

@kittaakos kittaakos merged commit ad2cfc8 into main Feb 17, 2021
@kittaakos kittaakos deleted the gh-10 branch February 17, 2021 07:56
@per1234 per1234 added topic: code Related to content of the project itself topic: serial monitor Related to the Serial Monitor type: imperfection Perceived defect in any part of project labels Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ubidefeo ubidefeo ubidefeo approved these changes

@per1234 per1234 per1234 approved these changes

@rsora rsora Awaiting requested review from rsora

Assignees
No one assigned
Labels
topic: code Related to content of the project itself topic: serial monitor Related to the Serial Monitor type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IDE unresponsive when uploading with Serial Monitor open and the board printing messages with no delays
3 participants
@kittaakos @ubidefeo @per1234