Skip to content

chore: update electron dependency + Node.js #2199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 26, 2023
Merged

chore: update electron dependency + Node.js #2199

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
00d5dcb
chore: update `prettier` config
Aug 24, 2023
22c1cf4
chore: format resources :lipstick:
Aug 24, 2023
b1bf3be
chore: use Node.js `>=18.17.0`
Aug 24, 2023
62736fa
chore(deps): update `[email protected]`
Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,10 @@ jobs:
- name: Checkout
uses: actions/checkout@v3

- name: Install Node.js 16.14
- name: Install Node.js 18.17
uses: actions/setup-node@v3
with:
node-version: '16.14'
node-version: '18.17'
registry-url: 'https://registry.npmjs.org'
cache: 'yarn'

Expand Down Expand Up @@ -131,10 +131,6 @@ jobs:
export CSC_FOR_PULL_REQUEST=true
fi

if [ "${{ runner.OS }}" = "Windows" ]; then
npm config set msvs_version 2017 --global
fi

npx node-gyp install
yarn install --immutable

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/check-i18n-task.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,10 @@ jobs:
- name: Checkout repository
uses: actions/checkout@v3

- name: Install Node.js 16.14
- name: Install Node.js 18.17
uses: actions/setup-node@v3
with:
node-version: '16.14'
node-version: '18.17'
registry-url: 'https://registry.npmjs.org'
cache: 'yarn'

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/compose-full-changelog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
env:
CHANGELOG_ARTIFACTS: changelog
# See: https://github.com/actions/setup-node/#readme
NODE_VERSION: 16.x
NODE_VERSION: '18.17'

jobs:
create-changelog:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/i18n-nightly-push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ jobs:
- name: Checkout
uses: actions/checkout@v3

- name: Install Node.js 16.14
- name: Install Node.js 18.17
uses: actions/setup-node@v3
with:
node-version: '16.14'
node-version: '18.17'
registry-url: 'https://registry.npmjs.org'
cache: 'yarn'

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/i18n-weekly-pull.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ jobs:
- name: Checkout
uses: actions/checkout@v3

- name: Install Node.js 16.14
- name: Install Node.js 18.17
uses: actions/setup-node@v3
with:
node-version: '16.14'
node-version: '18.17'
registry-url: 'https://registry.npmjs.org'
cache: 'yarn'

Expand Down
71 changes: 0 additions & 71 deletions docs/internal/Arm.md
View file
Open in desktop

This file was deleted.

18 changes: 11 additions & 7 deletions docs/internal/Ubuntu.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
### Building and start the app from the sources on Ubuntu Linux

Tested and verified on Ubuntu 18.04.4. The source will be checked out to `~/dev/git/arduino-ide`.
Tested and verified on Ubuntu 22.04. The source will be checked out to `~/dev/git/arduino-ide`.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chicken-egg problem: the main still does not support Node.js 18+. Here is what should work. The git checkout part differs

#!/bin/bash -i

sudo apt update \
&& sudo apt install --no-install-recommends --yes \
  git \
  gcc \
  curl \
  make \
  python3 \
  pkg-config \
  libx11-dev \
  libxkbfile-dev \
  build-essential \
  libsecret-1-dev \
&& wget -qO- https://raw.githubusercontent.com/nvm-sh/nvm/v0.35.3/install.sh | bash \
&& source ~/.bashrc \
&& nvm install 18.17 \
&& nvm use 18.17 \
&& nvm alias default 18.17 \
&& curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | sudo apt-key add - \
&& echo "deb https://dl.yarnpkg.com/debian/ stable main" | sudo tee /etc/apt/sources.list.d/yarn.list \
&& sudo apt update && sudo apt install --no-install-recommends yarn \
&& mkdir -p ~/dev/git/ \
&& rm -rf ~/dev/git/arduino-ide \
&& git clone https://github.com/arduino/arduino-ide.git ~/dev/git/arduino-ide \
&& git -C ~/dev/git/arduino-ide checkout origin/update-infra -b update-infra \
&& yarn --cwd ~/dev/git/arduino-ide \
&& yarn --cwd ~/dev/git/arduino-ide/electron-app rebuild \
&& yarn --cwd ~/dev/git/arduino-ide build \
&& yarn --cwd ~/dev/git/arduino-ide start


> ❗ This is an all-in-one script to create production-ready, minified code; you will need ~16GB of RAM to run it. This script will install libraries you might already have on your system and change the default Node.js version you do not want. If you look for documentation on development, please reference [this](../development.md#prerequisites) section instead.

```
#!/bin/bash -i
Expand All @@ -11,23 +13,25 @@ sudo apt update \
gcc \
curl \
make \
python \
python3 \
pkg-config \
libx11-dev \
libxkbfile-dev \
build-essential \
libsecret-1-dev \
&& wget -qO- https://raw.githubusercontent.com/nvm-sh/nvm/v0.35.3/install.sh | bash \
&& source ~/.bashrc \
&& nvm install 16 \
&& nvm use 16 \
&& nvm alias default 16 \
&& nvm install 18.17 \
&& nvm use 18.17 \
&& nvm alias default 18.17 \
&& curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | sudo apt-key add - \
&& echo "deb https://dl.yarnpkg.com/debian/ stable main" | sudo tee /etc/apt/sources.list.d/yarn.list \
&& sudo apt update && sudo apt install --no-install-recommends yarn \
&& mkdir -p ~/dev/git/ \
&& rm -rf ~/dev/git/arduino-ide \
&& git clone --depth 1 https://github.com/arduino/arduino-ide.git ~/dev/git/arduino-ide \
&& yarn --cwd ~/dev/git/arduino-ide \
&& yarn --cwd ~/dev/git/arduino-ide rebuild:electron \
&& yarn --cwd ~/dev/git/arduino-ide/electron-app start
&& yarn --cwd ~/dev/git/arduino-ide/electron-app rebuild \
&& yarn --cwd ~/dev/git/arduino-ide build \
&& yarn --cwd ~/dev/git/arduino-ide start
```
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"license": "AGPL-3.0-or-later",
"private": true,
"engines": {
"node": ">=16.14.0 <17"
"node": ">=18.17.0 <21"
},
"devDependencies": {
"@theia/cli": "1.39.0",
Expand Down