Skip to content

fix: relaxed saveAll if no Internet connection #2080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2023
Merged

fix: relaxed saveAll if no Internet connection #2080

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions arduino-ide-extension/src/browser/theia/core/application-shell.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,22 +8,19 @@ import {
TabBar,
Widget,
} from '@theia/core/lib/browser';
import {
ConnectionStatus,
ConnectionStatusService,
} from '@theia/core/lib/browser/connection-status-service';
import { nls } from '@theia/core/lib/common/nls';
import { MessageService } from '@theia/core/lib/common/message-service';
import { inject, injectable } from '@theia/core/shared/inversify';
import { ApplicationConnectionStatusContribution } from './connection-status-service';
import { ToolbarAwareTabBar } from './tab-bars';

@injectable()
export class ApplicationShell extends TheiaApplicationShell {
@inject(MessageService)
private readonly messageService: MessageService;

@inject(ConnectionStatusService)
private readonly connectionStatusService: ConnectionStatusService;
@inject(ApplicationConnectionStatusContribution)
private readonly connectionStatusService: ApplicationConnectionStatusContribution;

override async addWidget(
widget: Widget,
Expand Down Expand Up @@ -64,9 +61,8 @@ export class ApplicationShell extends TheiaApplicationShell {
}

override async saveAll(options?: SaveOptions): Promise<void> {
if (
this.connectionStatusService.currentStatus === ConnectionStatus.OFFLINE
) {
// When there is no connection between the IDE2 frontend and backend.
if (this.connectionStatusService.offlineStatus === 'backend') {
this.messageService.error(
nls.localize(
'theia/core/couldNotSave',
Expand Down