Skip to content

fix: do not exclude cloud sketch diagnostics #2037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2023
Merged

fix: do not exclude cloud sketch diagnostics #2037

merged 1 commit into from
May 5, 2023

Conversation

kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Apr 28, 2023 •
edited
Loading

Motivation

To enable diagnostics for cloud sketches.

Change description

As part of PROEDITOR-50, the error markers have been disabled for built-ins (daedae1). Then cloud sketches were added to IDE2, but they're in the same root folder where the built-ins are. This PR relaxes the diagnostics filtering and lets it work for the cloud sketchbook cache folder.

Steps to verify:

  • Error diagnostics work with ordinary sketches,
  • Error diagnostics work with cloud sketches independently from the user's logged-in status,
  • There are still no error diagnostics for built-ins and code from platforms if you navigate into them. (basically, what is in directory.data but not in directory.data/RemoteSketchbook/ArduinoCloud get filtered)

Other information

Closes #669

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

fix: do not exclude cloud sketch diagnostics
e0674c6 
PROEDITOR-50: error markers have been disabled for built-ins (daedae1).
Relaxed the error marker filtering for cloud sketches.

Closes #669

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project topic: cloud Related to Arduino Cloud and cloud sketches labels Apr 28, 2023
@kittaakos kittaakos requested review from AlbyIanna and per1234 April 28, 2023 13:16
@kittaakos kittaakos self-assigned this Apr 28, 2023
@davegarthsimpson davegarthsimpson requested review from davegarthsimpson and removed request for AlbyIanna May 4, 2023 07:24
davegarthsimpson
davegarthsimpson approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@davegarthsimpson davegarthsimpson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, no issues!

@kittaakos kittaakos merged commit e6828f8 into main May 5, 2023
@kittaakos kittaakos deleted the #669 branch May 5, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

@davegarthsimpson davegarthsimpson davegarthsimpson approved these changes

Assignees

@kittaakos kittaakos

Labels
topic: cloud Related to Arduino Cloud and cloud sketches topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pulled remote sketches don't show error underlines and markers
3 participants
@kittaakos @per1234 @davegarthsimpson