Skip to content

fix: use text --format for the CLI #1947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2023
Merged

fix: use text --format for the CLI #1947

merged 1 commit into from
Mar 13, 2023

Conversation

kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Mar 10, 2023 •
edited
Loading

Motivation

IDE2 does not start with the "arduino.cli.daemon.debug": true settings. This PR drops the jsonmini --format and uses the CLI's new capability to get the daemon address.

Change description

Other information

To verify:

  • Use the "arduino.cli.daemon.debug": true settings,
  • Stop IDE2.
  • Start IDE2 from a terminal:
    • IDE2 starts and
    • the log output in the terminal contains the gRPC log info.

Ref: arduino/arduino-cli#2003
Closes #1942

The PR will be marked as ready when arduino/arduino-cli#2101 is merged, and IDE2 pins a hash from the master. ✅

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project topic: CLI Related to Arduino CLI labels Mar 10, 2023
@kittaakos kittaakos self-assigned this Mar 10, 2023
@kittaakos kittaakos marked this pull request as ready for review March 10, 2023 13:38
fix: use text --format for the CLI
a68577f 
`Can't write debug log: available only in text format` error is thrown
by the CLI if the `--debug` flag is present.

Ref: arduino/arduino-cli#2003
Closes #1942

Signed-off-by: Akos Kitta <[email protected]>
per1234
per1234 approved these changes Mar 12, 2023
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Akos!

@kittaakos kittaakos merged commit ec24b68 into main Mar 13, 2023
@kittaakos kittaakos deleted the #1942 branch March 13, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

Assignees

@kittaakos kittaakos

Labels
topic: CLI Related to Arduino CLI topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2.0.4 does not start with "arduino.cli.daemon.debug": true settings
2 participants
@kittaakos @per1234