Skip to content

Modify tempBuildFolderMD5Hash folderName #1907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Modify tempBuildFolderMD5Hash folderName #1907

wants to merge 1 commit into from

Conversation

davegarthsimpson
Copy link
Contributor

@davegarthsimpson davegarthsimpson commented Feb 22, 2023 •
edited
Loading

Motivation

As explained in 1809 (Comment), newer versions of the CLI will require a change in our sketches-service-impl.ts. The hashed folder name should be replaced with the newly supported path, pattern arduino/sketches/<hash>.

Change description

Modifies our folderName return value for method tempBuildFolderMD5Hash of sketches-service-impl.ts.

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@davegarthsimpson davegarthsimpson mentioned this pull request Feb 22, 2023
Closed
4 tasks
@davegarthsimpson davegarthsimpson added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Feb 22, 2023
kittaakos
kittaakos suggested changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be fixed with the updated CLI together.

@per1234 per1234 added the conclusion: duplicate Has already been submitted label Feb 22, 2023
@kittaakos kittaakos deleted the modify-temp-build-folder branch February 23, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kittaakos kittaakos kittaakos requested changes

Assignees
No one assigned
Labels
conclusion: duplicate Has already been submitted topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davegarthsimpson @kittaakos @per1234