Skip to content

feat: removed encoding from the status bar #1804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2023
Merged

feat: removed encoding from the status bar #1804

merged 1 commit into from
Jan 11, 2023

Conversation

kittaakos
Copy link
Contributor

Motivation

The editor encoding is not represented on the status bar anymore.

Change description

Start IDE, and see that the encoding is not present in the UI:

Screen Shot 2023-01-06 at 13 38 10

Other information

Closes #1393

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jan 6, 2023
@kittaakos kittaakos requested review from AlbyIanna and per1234 January 6, 2023 12:39
per1234
per1234 approved these changes Jan 7, 2023
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Akos!

@kittaakos kittaakos merged commit 287b2e3 into main Jan 11, 2023
@kittaakos kittaakos deleted the #1393 branch January 11, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlbyIanna AlbyIanna AlbyIanna approved these changes

@per1234 per1234 per1234 approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove encoding from status bar
3 participants
@kittaakos @AlbyIanna @per1234