fix: escaped regex chars in pattern #1622
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If regex patterns are not correctly escaped, they will break. Such as the
File
>Sketchbook
issue when there is a sketch with the following invalid name:bar++
.Change description
is-valid-path
check. Otherwise, on Windows, it's impossible to open a sketch in the following way:"Arduino IDE.exe" "..\\..\\Documents\\Arduino\\bar++"
input will give a false negative result.Other information
Closes #1600
Reviewer checklist