Skip to content

fix: avoid ENOTDIR when opening second instance. #1617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 10, 2022
Merged

fix: avoid ENOTDIR when opening second instance. #1617

merged 2 commits into from
Nov 10, 2022

Conversation

kittaakos
Copy link
Contributor

Motivation

To allow opening a second sketch from the command line.

Change description

  • Fix incorrect logic when detecting if the arg is a valid sketch,
  • Allow opening a second instance on macOS.

Other information

Closes #1590

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

Akos Kitta added 2 commits November 2, 2022 16:36
fix: avoid ENOTDIR when opening second instance.
0af858a 
If the resource is a file, do not try to `readdir`, but return undefined

Closes #1590

Signed-off-by: Akos Kitta <[email protected]>
fix: allow second instance on macOS
6e6d647 
Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Nov 2, 2022
@kittaakos kittaakos marked this pull request as ready for review November 7, 2022 10:27
per1234
per1234 approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified this fixes #1590 on Windows and Linux.

Thanks Akos!

AlbyIanna
AlbyIanna approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@AlbyIanna AlbyIanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working perfectly on MacOS too.

LGTM 🚀

@kittaakos kittaakos merged commit 103acc4 into main Nov 10, 2022
@kittaakos kittaakos deleted the #1590 branch November 10, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlbyIanna AlbyIanna AlbyIanna approved these changes

@per1234 per1234 per1234 approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Additional sketches can't be opened via file association/command line argument
3 participants
@kittaakos @AlbyIanna @per1234