Skip to content

#1525 Removed the real_name of the libraries #1528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2022
Merged

#1525 Removed the real_name of the libraries #1528

merged 1 commit into from
Oct 5, 2022

Conversation

kittaakos
Copy link
Contributor

Motivation

Align gRPC APIs with the most recent Arduino CLI. The Library#real_name has been removed from the gRPC API: arduino/arduino-cli#1890

This PR switches from real_name to name in the UI, as the name is the canonical form provided by the CLI.

Change description

Other information

How to verify:

  • start the IDE2,
  • open the library manager widget and type SparkFun color lcd in the search <input>, (expected a single result: SparkFun Color LCD Shield)
  • if the library is installed, uninstall it by clicking on UNINSTALL,
  • this should wipe the library without any errors,
  • install the SparkFun Color LCD [email protected],
  • open File > Examples> verify that you see SparkFun Color LCD Shield as the grouping menu item. Like this:

Screen Shot 2022-10-05 at 11 50 02

Closes #1525

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

Removed real_name of the libraries.
6cdecad 
It has been removed from the gRPC API: arduino/arduino-cli#1890

This PR switches from `real_name` to `name` in the UI, as the `name` is
the canonical form provided by the CLI.

Closes #1525

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Oct 5, 2022
francescospissu
francescospissu approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@francescospissu francescospissu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works well for me. Using getName() instead of getRealName() and grouping by name the examples it behaves as expected👍

per1234
per1234 approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is working perfectly for me. Thanks Akos!

@kittaakos
Copy link
Contributor Author

Thank you for the quick review ❤️

@kittaakos kittaakos merged commit 61a11a0 into main Oct 5, 2022
@kittaakos kittaakos deleted the #1525 branch October 5, 2022 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

@francescospissu francescospissu francescospissu approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IDE2 must not use deprecated real_name gRPC API
3 participants
@kittaakos @per1234 @francescospissu