-
-
Notifications
You must be signed in to change notification settings - Fork 431
#1442 Link resolver for lib/boards manager #1481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
19a57e9
to
e3d3784
Compare
a4b139e
to
461d12f
Compare
5cf48b7
to
a35f7c0
Compare
This PR has received all required support from the CLI and is ready for review. I have adjusted the examples in the PR description. Update: I did not update the screencast. |
@PaulZC could you please help us with the verification? Everything should work as in IDE 1.x (except for a few enhancements: arduino/arduino-cli#1904 (review) and the topic support for libs). Please note the updated example; underscore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is working perfectly in all the provided test cases as well as for a sampling of URIs from the wild collected by searching my >2 GB mega-sketchbook.
Thanks Akos, both for adding the missing feature, and also for going above and beyond by actually making the "Type" filter work for the first time in the 6 year history of the feature, as well as adding "Topic" filter support!
a35f7c0
to
6b6b31c
Compare
Thank you @kittaakos @per1234 @cmaglie - it works perfectly for me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and it works as expected. Code changes and behavior approved.👍
6b6b31c
to
5dc029d
Compare
Closes #1442 Signed-off-by: Akos Kitta <[email protected]>
5dc029d
to
380676e
Compare
This PR depends on #1530✅Motivation
To search in lib/boards manager from a particular URL.
In action:
1442.mp4
Test with:
See the specs and #1442 how it works.
Change description
Other information
Closes #1442
Reviewer checklist