Skip to content

#1442 Link resolver for lib/boards manager #1481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2022
Merged

#1442 Link resolver for lib/boards manager #1481

merged 1 commit into from
Oct 7, 2022

Conversation

kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Sep 21, 2022

This PR depends on #1530


Motivation

To search in lib/boards manager from a particular URL.

In action:

1442.mp4

Test with:

void setup() {}
void loop() {}
// Additional Board Manager URL:
// https://raw.githubusercontent.com/sparkfun/Arduino_Apollo3/main/package_sparkfun_apollo3_index.json
//
// http://boardsmanager/All#SparkFun_Apollo3
// ~http://boardsmanager/All#SparkFun%20Apollo3~ UNSUPPORTED. Use underscore (_) instead of `%20` (URL encoded space)
// http://librarymanager/All#SparkFun_u-blox_GNSS
// ~http://librarymanager/All#SparkFun%20u-blox%20GNSS~ UNSUPPORTED. Use underscore (_) instead of `%20` (URL encoded space)
// http://librarymanager/All/Display#SparkFun
// http://librarymanager/All/Sensors#SparkFun
// http://librarymanager/#SparkFun
// http://librarymanager/Updatable/Display#SparkFun
// http://librarymanager/All#SparkFun_u-blox_GNS
// http://boardsmanager#SAMD
// http://boardsmanager/Arduino%40Heart#littleBits
// http://librarymanager#WiFiNINA
// http://librarymanager/All#SparkFun_u-blox_GNSS
// http://librarymanager/All/Device%20Control#Servo
// http://librarymanager/All/Signal%20Input%2FOutput#debouncer

See the specs and #1442 how it works.

Change description

Other information

Closes #1442

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos changed the title #1442 Link resolved for lib/boards manager #1442 Link resolves for lib/boards manager Sep 21, 2022
@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project topic: CLI Related to Arduino CLI labels Sep 26, 2022
@kittaakos kittaakos force-pushed the #1442-signed branch 3 times, most recently from a4b139e to 461d12f Compare September 26, 2022 08:27
@kittaakos kittaakos changed the title #1442 Link resolves for lib/boards manager #1442 Link resolver for lib/boards manager Sep 26, 2022
@kittaakos kittaakos added the status: on hold Do not proceed at this time label Sep 28, 2022
@kittaakos kittaakos marked this pull request as draft September 28, 2022 14:11
@kittaakos kittaakos force-pushed the #1442-signed branch 2 times, most recently from 5cf48b7 to a35f7c0 Compare October 4, 2022 15:21
@kittaakos kittaakos removed the status: on hold Do not proceed at this time label Oct 4, 2022
@kittaakos kittaakos marked this pull request as ready for review October 4, 2022 15:24
@kittaakos
Copy link
Contributor Author

kittaakos commented Oct 4, 2022

This PR has received all required support from the CLI and is ready for review. I have adjusted the examples in the PR description.

Update: I did not update the screencast.

@kittaakos
Copy link
Contributor Author

@PaulZC could you please help us with the verification? Everything should work as in IDE 1.x (except for a few enhancements: arduino/arduino-cli#1904 (review) and the topic support for libs). Please note the updated example; underscore _ must be used in the hash, not %20. Let us know how it works for you. Thank you!

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is working perfectly in all the provided test cases as well as for a sampling of URIs from the wild collected by searching my >2 GB mega-sketchbook.

Thanks Akos, both for adding the missing feature, and also for going above and beyond by actually making the "Type" filter work for the first time in the 6 year history of the feature, as well as adding "Topic" filter support!

@PaulZC
Copy link

PaulZC commented Oct 5, 2022

Thank you @kittaakos @per1234 @cmaglie - it works perfectly for me.
Sincere best wishes,
Paul

Copy link
Contributor

@francescospissu francescospissu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works as expected. Code changes and behavior approved.👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: CLI Related to Arduino CLI topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Are librarymanager and boardmanager links still clickable with IDE v2?
4 participants