Skip to content

fix board selection and workspace input dialogs width and height #1406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 20, 2022
Merged

fix board selection and workspace input dialogs width and height #1406

merged 5 commits into from
Sep 20, 2022

Conversation

AlbyIanna
Copy link
Contributor

Motivation

Some dialogs have unexpected behaviours as described in #1350

Change description

fixed width and height of workspace input dialog and board selection dialog

Other information

Closes #1350

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@AlbyIanna AlbyIanna self-assigned this Sep 6, 2022
@AlbyIanna AlbyIanna added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Sep 6, 2022
@AlbyIanna AlbyIanna marked this pull request as draft September 7, 2022 10:42
@AlbyIanna AlbyIanna marked this pull request as ready for review September 15, 2022 07:37
@kittaakos
Copy link
Contributor

Having this giant hard-coded length for the new sketch file dialog only while having the default everywhere else is an unacceptable change. #1350 (comment)

New:
Screen Shot 2022-09-15 at 11 06 40

Rename:
Screen Shot 2022-09-15 at 11 06 51

Delete:
Screen Shot 2022-09-15 at 11 08 47

The boards list still disappears when I filter: #1350 (comment)

no_list.mp4

kittaakos
kittaakos suggested changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not fix #1350. See why: #1406 (comment).

@per1234 per1234 mentioned this pull request Sep 16, 2022
Closed
3 tasks
@AlbyIanna AlbyIanna requested a review from kittaakos September 16, 2022 06:56
@91volt
Copy link

91volt commented Sep 19, 2022 •
edited
Loading

Checked the build, the delete dialog is missing the fixed width:
Schermata 2022-09-19 alle 15 29 37

Once it is fixed the PR is ok for me

kittaakos
kittaakos reviewed Sep 19, 2022
View reviewed changes
Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The New, Rename, and Delete tabs have different sizes:
Screen Shot 2022-09-19 at 18 05 28

Screen Shot 2022-09-19 at 18 05 48

Screen Shot 2022-09-19 at 18 06 12

The board list height changes when filtering in the list (#1350 (comment)):

lis_resize.mp4

Should this PR cover #1350 (comment)? If yes, let's make this #1382 dependent. You can also cherry-pick the overflow changes or copy them here.

Screen Shot 2022-09-19 at 18 06 32

@AlbyIanna AlbyIanna force-pushed the fix-dialogs-ui branch 2 times, most recently from 60819f1 to 2603e05 Compare September 20, 2022 07:14
@AlbyIanna
Copy link
Contributor Author

Thanks for the review @kittaakos and @91volt. I've fixed the remaining dialogs, now the min-size for any dialog is set by default to 480px.

I've fixed the board list changing size when filtering, and took the liberty to change the UI when no board is found for the search made by to user:
image
The alternative was to show a white empty rectangle, which wasn't very nice to me. @91volt do you like it? ☝️

@AlbyIanna
Copy link
Contributor Author

Should this PR cover #1350 (comment)? If yes, let's make this #1382 dependent. You can also cherry-pick the overflow changes or copy them here.

@kittaakos since #1382 is already approved, I'm okay with waiting for it to be merged.

@AlbyIanna AlbyIanna requested a review from kittaakos September 20, 2022 07:25
@kittaakos
Copy link
Contributor

@kittaakos since #1382 is already approved, I'm okay with waiting for it to be merged.

Could you please rebase? #1382 has been merged. Your branch is three commits behind the main. Thank you!

Screen Shot 2022-09-20 at 12 02 58

@AlbyIanna
Copy link
Contributor Author

Could you please rebase? #1382 has been merged. Your branch is three commits behind the main. Thank you!

Done. I've also fixed the Additional Boards URL focus outline.

image

kittaakos
kittaakos approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great. Thank you!

@AlbyIanna AlbyIanna merged commit 8a59959 into main Sep 20, 2022
@AlbyIanna AlbyIanna deleted the fix-dialogs-ui branch September 20, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kittaakos kittaakos kittaakos approved these changes

@91volt 91volt 91volt approved these changes

Assignees

@AlbyIanna AlbyIanna

Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix dialogs UI scalability vol 2 - Unexpected dialog layouts
3 participants
@AlbyIanna @kittaakos @91volt