Skip to content

#1390 Coerce a semver when calculating updatables #1391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2022
Merged

#1390 Coerce a semver when calculating updatables #1391

merged 1 commit into from
Sep 5, 2022

Conversation

kittaakos
Copy link
Contributor

Motivation

Fix updatable state calculation with "relaxed-semver" (arduino/arduino-cli#1727 (comment)).

To verify:

From the main it detects updates, installs PubSubClient, and logs already installed.

Change description

Other information

Closes #1390

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Sep 3, 2022
per1234
per1234 approved these changes Sep 4, 2022
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works perfectly.

Thanks Akos!

@kittaakos kittaakos changed the base branch from #1380 to main September 5, 2022 07:12
@kittaakos kittaakos merged commit df3a34e into main Sep 5, 2022
@kittaakos kittaakos deleted the #1390 branch September 5, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

@davegarthsimpson davegarthsimpson Awaiting requested review from davegarthsimpson

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IDE incorrectly shows [email protected] as updatable after an Install All automatic update
2 participants
@kittaakos @per1234